Skip to content

ci: remove unused flag #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glebbash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: remove unused flag #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion composite-actions/nodejs-generic-api/staging-cloud-deploy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ This is typical action, to deploy nodejs api application to GKE Autopilot cluste
user-email-name: <name of the user email in secret manager> # default - iam-test-token-email
user-password-name: <name of the user password in secret manager> # default - iam-test-token-password
update-dns: always # default - if-missing
with-component-tests: 'false' # default - 'true'
```

### Requirements
Expand Down
5 changes: 0 additions & 5 deletions composite-actions/nodejs-generic-api/staging-cloud-deploy/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ inputs:
default: false
type: boolean
required: false
with-component-tests:
description: "If true runs component tests"
default: 'true'
required: false

runs:
using: "composite"
Expand Down Expand Up @@ -102,7 +98,6 @@ runs:

- name: Component tests
uses: extenda/actions/component-tests@v0
if: ${{ inputs.with-component-tests == 'true' }}
with:
auth-token: ${{ env.IAM_TOKEN }}
base-url: ${{ inputs.service-url }}
Expand Down