Closed
Conversation
Contributor
|
Hello, ans thank you for your pull request. It looks like this adds an option to this module that, when set, modifies the global Node.js environment. Unfortunately global modification is not something we would accept as a feature to this module. But the good news is that since you are modifying the global environment, there is no need to add it to this module: simply make the modification in your code or even publish it to npm as it's own module to use. |
Author
|
It may be better to mention the solution in our document. |
|
Would PR #908 be a better solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.