Move markdown references to bottom of file#280
Closed
cianclarke wants to merge 1 commit intoexpressjs:masterfrom
Closed
Move markdown references to bottom of file#280cianclarke wants to merge 1 commit intoexpressjs:masterfrom
cianclarke wants to merge 1 commit intoexpressjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown reference style links & image refs have been embedded with the example implementations section - presumably to group these common entitites together. However, examining the definition of references in CommonMark, references are always separated by a new line character.
This may invalidate the whole reason for in-lining these references, so I've moved them to the bottom of the file, newline separated to continue some form of logical grouping.
This should fix #248