feat(redesign): Homepage Features and Banner component#2204
feat(redesign): Homepage Features and Banner component#2204g-francesca merged 36 commits intoredesignfrom
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
bjohansebas
dismissed
their stale review
Lol, I didn’t mean to approve this PR, it was the other one, haha
astro/src/pages/[lang]/index.astro
Outdated
| </Container> | ||
| <!-- TODO: Banner added for demo purposes, will be removed before release, or replaced with a new one --> | ||
| <Banner | ||
| id="express-5-1-0-lts" |
There was a problem hiding this comment.
What is this ID for? I don’t think it’s necessary, and we’ll most likely forget to update it, so it’s probably better not to have it.
There was a problem hiding this comment.
@bjohansebas When the user dismisses the banner, it writes banner-dismissed-{id} to localStorage so the banner stays hidden in this case. Since the Banner is optionally dismissible, I reviewed the Banner type so that you don't need to pass the id in case dismissible is false (which is the default).
| </li> | ||
| </ul> | ||
| </Container> | ||
| <!-- TODO: Banner added for demo purposes, will be removed before release, or replaced with a new one --> |
There was a problem hiding this comment.
It will be replaced with the blog post about the redesign
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
Those are the only comments I have about the implementation :)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
3 participants
Preview
Note: PR created as draft while merging #2203 (since this branch was created from
redesign-homepagebranch)This PR includes new homepage sections:
Featurespattern component displaying a 4-card grid (Performance, APIs, Middleware, Web Applications) with a responsive layout (stacked on mobile, side-by-side title/cards on desktop). Includes a newCardprimitive and corresponding i18n strings.Bannerpattern component for full-width notification banners. Supportsinfo/warningvariants, optional date-range visibility (startDate/endDate), and optional dismiss-to-localStoragebehaviour. Dismissed state is applied via an inline<style>injected before first paint to prevent layout shift on load.Other changes
--blue-975color token and updated--color-bg-info/--color-border-infodark-mode values for better contrast.Layout.astrofor readability; extended it to hide previously-dismissed banners before paint.Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.