Add CONTRIBUTING.md and CODE_OF_CONDUCT.md files#6604
Add CONTRIBUTING.md and CODE_OF_CONDUCT.md files#6604RaginiSharma01 wants to merge 5 commits intoexpressjs:masterfrom
Conversation
|
I have added the contributing.d and code_of_conduct.md |
|
The links should be updated like @ShubhamOulkar did in #6601 and point to files from expressjs/.github repository (see #6593 (comment)). Additionally, the link to the Code of Conduct is given at the bottom of README and that's where it should be changed (it's a collapsed reference link): Line 272 in 98c85eb |
RaginiSharma01
left a comment
RaginiSharma01
left a comment
There was a problem hiding this comment.
i have made changes . and added the code of conduct
There was a problem hiding this comment.
Please keep the PR focused, this change is unnecessary
There was a problem hiding this comment.
It would be better if you created a new PR, since this change could block the goal of the current one, which is to bring that file back.
There was a problem hiding this comment.
@RaginiSharma01 This change is still here. Please remove the changes you made here, they don't belong in this PR
code_of_conduct.md
Outdated
There was a problem hiding this comment.
The content of this file should say something like "The code of conduct is located in https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md" rather than bringing back the full content, since we don’t want to maintain two versions in different places.
Contributing.md
Outdated
There was a problem hiding this comment.
|
@RaginiSharma01 Could you please make the changes I asked for? |
RaginiSharma01
left a comment
RaginiSharma01
left a comment
There was a problem hiding this comment.
@bjohansebas now check i have updated the links and deleted the files for code of conduct and contributing md
|
This PR made sense because it was bringing back the important files, but now it's just another repeated PR of #6601. Could you please create the |
|
@bjohansebas so i have to create those files again right , replace the files with links https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md |
|
Unless GitHub is broken, those files are not showing up for me |
|
@bjohansebas this is the same README.md PR scam. Don't even waste your time reviewing. |
|
I’m going to close this since there hasn’t been any activity and most of the links have already been updated. If any are still missing, please report it |
4 participants
No description provided.