Remove res.vary() (no arguments) signature

[tunniclm]

Changed res.vary() to throw TypeError if no field argument is passed or if the value of field argument is an empty array. (Similar to how res.sendFile() deals with a missing path argument).

[dougwilson]

The vary module already does this check and throw, no?

[tunniclm]

It does throw if field is missing, but not if it is an empty array (I think it does nothing in that case). Maybe that is ok?

[tunniclm]

Happy to remove the check/throw or change it if it is still good to test if field is an empty array. I guess that check was only really to catch a deprecated use case, so I imagine the check can just be removed entirely.

[dougwilson]

Yea, the idea behind the change is to remove any logic from Express itself, and just have it pass-through to the dependency.

[tunniclm]

OK, updates. I've removed the test that passes an empty array and kept the no args test. I think that's ok, but I'm happy to either remove the no args or add a test for empty array that checks it has no effect, if that fits better.

[dougwilson]

add a test for empty array that checks it has no effect, if that fits better.

Yea, let's keep the test, but update the expected outcome to what it is with the change.

[tunniclm]

OK, done.

[tunniclm]

shouldNotHaveHeader() is no longer used, so I removed that as well.

[hacksparrow]

@tunniclm coverage has decreased by a fraction, otherwise looks good to me.

[tunniclm]

As mentioned in the other similar pull request (see #2939 (comment)), the slight reduction in coverage is due to the reduced number of lines in the changed file (response.js).

[dougwilson]

Can you add this as an additional test rather than altering the existing test? I think both the former test and the test you changed it to have merit and would like to have both.

[dougwilson]

Hi @tunniclm, can you address the comment regarding the test and possibly rebase this pull request? Then I think everything is resolved to merge after that.

[tunniclm]

Updated.

[dougwilson]

Merged into the 5.0 branch.