Update path regexp functionality

[blakeembrey]

• Old asterisk functionality is obsolete
• Adds the repeated parameters mentioned in Allow + quantifier into path pattern #2134

This will break backward compatibility

[dougwilson]

Thanks! Right now master is pending a 4.4.x patch release. I'll merge this in once it get back to the 4.5 release code :)

[dougwilson]

Wait, is this a breaking change? Why the changes to the test files? Will people's stuff break if they are using the paths that you removed?

[blakeembrey]

@dougwilson It is a breaking change since it changes the way routes match. It's directly related to (and implemented from) #2057.

[dougwilson]

Wait, is this a breaking change?

Ah, I see you noted it will in your commit. Looks like it'll be scheduled for express 5.x, then :)

[dougwilson]

As an update, this has not been moved anywhere yet because I need to find a way to warn people so they can change the way their routes are declared, otherwise they'll update to 5.0 and crap will just be broken and no one will upgrade... :(

[blakeembrey]

@dougwilson Should I attempt to add warnings in path-to-regexp@0.1.x? Then you could just add a static check for /* or * and recommend using app.use instead?

[dougwilson]

Should I attempt to add warnings in path-to-regexp@0.1.x?

Well, not unless the user can also change their paths to have the same functionality and not have warnings and still use 0.1.x.

[blakeembrey]

Closing in favour of #2530