feat(magic-redirect): migrate magic-redirect to codemod.com

[bjohansebas]

I’ve just migrated the codemod to use ast-grep, which is what Codemod uses under the hood. I copied the tests from the old CLI and added more tests to ensure it works correctly.

I didn’t remove the files from the old codemod that uses jscodeshift so this PR is easier to review. In the future, once we’ve completed all the migrations, we can remove the old CLI in a single PR

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​codemod.com/​jssg-types@​1.3.1

View full report

[bjohansebas]

Hey @expressjs/codemod-collaborators @AugustinMauroy @alexbit-codemod, I’d love your review here, this would be the first codemod to be released on the platform 🙂

[mohebifar]

Hey @bjohansebas! Thank you for using Codemod's JSSG and ast-grep! I just opened a PR to merge to your branch:

#92

I refactored the code to use JSSG's semantic analysis tools (node.definition()). That simplifies the code a lot while making it more reliable. So basically, after grabbing all $OBJ.$METHOD('back') (with METHOD being either location or redirect), we check the definition of $OBJ and make sure its part of the function params. And use the same parameters list to grab the first param (req)

[AugustinMauroy]

what if there are another method called redirect ? from my comprehension it's will be modified so we need to create a new workflow logic:

catch express import => with that catch all app => catch all usage of the app => read the call back => modify the arg

It's look complex but there are an esay way which is https://docs.codemod.com/jssg/semantic-analysis (on user lad migration we don't use it for now since this api is new)

in overall it's LGTM.

[AugustinMauroy]

use codemod dir recipes was a mistake from userland migration

[bjohansebas]

what if there are another method called redirect ? from my comprehension it's will be modified so we need to create a new workflow logic:

i think this would go further than necessary and would be fairly extreme cases, I’d prefer to keep it simple as it is right now. What do you think?

[AugustinMauroy]

what if there are another method called redirect ? from my comprehension it's will be modified so we need to create a new workflow logic:

i think this would go further than necessary and would be fairly extreme cases, I’d prefer to keep it simple as it is right now. What do you think?

I didn't have strong opinions but start by that and then update if there are report

[bjohansebas]

Since it's end of year and many of us are on vacation, and I'm unsure if they're available to approve the release, I'll merge this to main, but we won't do the release yet (i.e., create the tag that'll deploy to the platform) as it needs another person's approval. Hopefully, the second week of January or sooner if possible, we can do the release when the team is back, along with the other codemods.