ci: disable fail-fast in CI workflow#565
Merged
wesleytodd merged 1 commit intoexpressjs:masterfrom Jan 8, 2025
Merged
Conversation
bjohansebas
approved these changes
Dec 6, 2024
UlisesGascon
approved these changes
Dec 20, 2024
wesleytodd
approved these changes
Jan 8, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
THANK YOU! This is the most frustrating setting. We also had this in the test scripts in some cases so mocha would do this and I never understood it. If 5 tests fail in a related way I dont want to waste time thinking it is one test failing. Same as with node versions, why have to re-run it to see just another failure in a different node version after pusing?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
fail-fast: falseto the job strategy matrix to ensure that the tests run on all node versions even if one of them fails.