Add Java analyzer for Annalyns Infiltration#130
Add Java analyzer for Annalyns Infiltration#130sanderploegsma merged 4 commits intoexercism:mainfrom
Conversation
|
Hey Gyoo, thanks for submitting a PR! I would suggest to change this to draft, and wait until this major reformat of the analyzer is applied |
|
Thank you for your feedback. I will monitor the other issue for now :) |
|
Hi @Gyoo, we have finished refactoring the test setup, so feel free to update your branch with the changes on |
sanderploegsma
left a comment
There was a problem hiding this comment.
Please also add a couple of smoke tests for this exercise to the tests/ directory. We aim to have at least two: one with an exemplar solution and one or more with a solution that is designed to receive some feedback from the analyzer.
Have a look at the smoke tests for the other exercises to see what is expected.
src/main/java/analyzer/exercises/annalynsinfiltration/AvoidBooleanLiteralReturns.java
Outdated
Show resolved
Hide resolved
src/test/resources/analyzer/AnalyzerIntegrationTest.annalynsinfiltration.Optimal.approved.txt
Show resolved
Hide resolved
|
@sanderploegsma I made the changes you requested but I'm wondering if I'm missing something regarding smoke tests : I have one exemplar solution and 4 other tests to trigger the different analyzer cases. Do I need something more ? |
|
The main difference between the JUnit tests in |
|
Thank you for your feedback. I'll have a second look at this then! |
sanderploegsma
left a comment
There was a problem hiding this comment.
Other than my one open question this looks good to go, thanks!
Note for maintainers: make sure the website-copy PR is merged first
|
Thanks for your contribution @Gyoo! 🎉 |
Fixes #98
I also added the analyzer comments to the website-copy repository : exercism/website-copy#2323