A11y: set aria-expanded to the toggle button. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
trallard
approved these changes
Sep 3, 2024
gabalafou
approved these changes
Sep 10, 2024
Contributor
gabalafou
left a comment
gabalafou
left a comment
There was a problem hiding this comment.
Thank you, this looks good to go!
Contributor
|
Just for the record, I built the docs locally with |
Member
|
thanks for the improvement, and for the follow-up linting update! FYI I have very few cycles to maintain this repository - if either of you are interested please let me know and I can add you |
Contributor
|
I'm interested :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quansight-Labs/czi-scientific-python-mgmt#77
The second commit also run prettify to fix some formatting issues.