Display hide hint text when admonition is expanded #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
choldgraf
approved these changes
Dec 22, 2023
Member
choldgraf
left a comment
choldgraf
left a comment
There was a problem hiding this comment.
LGTM - thanks for improving consistency here
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a puzzling inconsistency between the toggle button created with the
toggledirective, versus one created via anadmonition.For the toggle-directive button, you click "Click to show", the widget expands, and the text is replaced with "Click to hide".
But for the admonition-directive button, you click "Click to show", the widget expands, and the text goes away.
You can corroborate this behavior at the docs.
This PR makes the admonition behavior match the toggle-directive behavior.