Skip to content

Conversation

@rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Nov 23, 2023

This fixes a bug where the inline images do not take a height of zero override unless they are of display: block.

This is the test site:
https://phispel.github.io/dropdown-height-bug/notebooks.html

css-dropdown-bug

See issue: jupyter-book/jupyter-book#1928

@welcome
Copy link

welcome bot commented Nov 23, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@choldgraf choldgraf merged commit 0a356c2 into master Nov 23, 2023
@welcome
Copy link

welcome bot commented Nov 23, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@rowanc1 rowanc1 deleted the bug/inline-images branch November 23, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants