Fix insertion of toggle hint into nested spans

[janssenhenning]

Possible fix for #44

This commit makes the query changing the text of the toggle button more specific
to not insert the hint in unrelated spans that are nested in the toggleable region

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[choldgraf]

this looks like a good fix to me!

one quick comment, could you just use the standard class selector approach instead of class=?

I think it'd be:

span.toggle-details__summary-text

Or if there's a rationale for not doing this, that's fine I just haven't seen this usage before

[janssenhenning]

@choldgraf No there was no particular reason for the selector like that. I switched it now.
I was working with XML XPaths a lot and not so much javascript and that's just the first thing that came to my mind

[choldgraf]

This looks good to me! Will check the output and merge if it looks OK

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️