ENH: Vertical flip for toggle icon #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
commented
Mar 23, 2022
|
;-) So the change is to down arrow (collapsed) / up arrow (expanded) rather than right arrow (collapsed) / down arrow (expanded)?
Yes, I think that's a better pairing than the other way. It may take a bit of time for my memory muscle to adjust to that but it makes more sense as a pair. The right/down pairing just felt really wrong (I am so used to it having the contrary meaning, albeit with solid triangle arrows, in eg directory/file tree views). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK @psychemedia you nerd sniped me 😅
This is a minor CSS change to make the admonition toggle "flip" instead of rotate.
Would be great to have feedback - does this seem more intuitive?
closes #38