✨ NEW: Use external markdown-it plugins#30
Merged
chrisjsewell merged 20 commits intomasterfrom Jul 10, 2021
Merged
Conversation
Member
|
Just seeing this in the css -- https://caniuse.com/css-masks is not in chrome/webkit which this uses. Mine currently look like this in Chrome here: https://executablebooks.github.io/markdown-it-docutils/: (changed the mask property on the second one...) |
Member
Author
|
Ah cheers, that could be it then 👍 |
Member
Author
|
Ah so furo uses https://github.com/postcss/autoprefixer (via gulp) during the css compliation, which auto-adds vendor prefixes (which is why I did not find e.g. |
Member
Author
3 tasks
|
Sorry to dig up this old PR. It doesn't look like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Replaced the (very adhoc) local markdown-it plugin for directives, with https://github.com/executablebooks/markdown-it-docutils, and in general it works 🎉 ! (some notes and todos below)
TODOS:
code/code-block/code-celldirectives; once that is done there will be > parity with the plugin it is replacing{code-block}does not get parsed as a directive, which needs to be fixed, i.e. the regex needs to include-markdown-it-docutils/dist/css/style.min.cssto./styles.css, but it would be good to have this updated automaticallyToken.mapfor all the (block) nodes@media (prefers-color-scheme: dark)to change between light and dark themes. This doesn't necessarily play well with the VS Code themes, so should think about either (a) if this is the best approach in the first place and/or (b) if we should override some of these variables.@rowanc1 it would be great if you give this a try (the dev instructions are in the README); it would be good for you to understand this use case for the markdown-it plugins, and maybe even get some idea for curvenote 😄
also cc @pradyunsg (as mentioned I borrowed some of your sass from Furo 😄)