👌 Improve admon plugin (add ??? support)#58
👌 Improve admon plugin (add ??? support)#58chrisjsewell merged 19 commits intoexecutablebooks:masterfrom KyleKing:more-admon
??? support)#58Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 92.90% 92.93% +0.02%
==========================================
Files 30 30
Lines 1748 1755 +7
==========================================
+ Hits 1624 1631 +7
Misses 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
KyleKing
changed the title
|
I hope you had a happy New Year! I just wanted to follow up and see if you had any feedback on this PR, thanks! |
|
Heya, sorry for the delayed response 😓 if you update this to fix the conflict we can look at getting it in |
|
Thanks, resolved and ready to merge now! |
chrisjsewell
changed the title
??? support)
chrisjsewell
left a comment
chrisjsewell
left a comment
There was a problem hiding this comment.
See comment, also could you add to the admon_plugin docstring, to note the new features, thanks
Done! All that is left is to figure out if the HTML is parsed properly |
chrisjsewell
left a comment
chrisjsewell
left a comment
There was a problem hiding this comment.
almost there thanks, see just some final "nitpick" questions
KyleKing
left a comment
KyleKing
left a comment
There was a problem hiding this comment.
Your feedback was helpful, and I'm happy to make any other changes, so let me know. Thanks again for sticking with this PR! I think this should now be ready for one last pass
chrisjsewell
left a comment
chrisjsewell
left a comment
There was a problem hiding this comment.
Looks great, thanks for your patience 😄
2 participants
Resolves: KyleKing/mdformat-admon#9
Extend the
admonplugin for themkdocs?-based collapsible syntax by displaying as a regular admonition