Make markdown_it.common.entities.entities a dict. Remove AttrDict#153
Closed
hukkin wants to merge 3 commits intoexecutablebooks:masterfrom
Closed
Make markdown_it.common.entities.entities a dict. Remove AttrDict#153hukkin wants to merge 3 commits intoexecutablebooks:masterfrom
markdown_it.common.entities.entities a dict. Remove AttrDict#153hukkin wants to merge 3 commits intoexecutablebooks:masterfrom
Conversation
Contributor
Author
|
Made a PR to remove AttrDict usage from mdit-py-plugins, so that would fix the test failure here. |
Contributor
Author
|
On another note, maybe |
markdown_it.common.entities.entities a dict. Remove AttrDict
Member
|
superseded by #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @chrisjsewell what's your thoughts on a change like this?
One test fails because of
AttDictusage inmdit-py-plugins, so would need to be fixed there first.mdit-py-pluginsusesAttrDictonly this one time, and doesn't useentitiesat all. Not sure how much or if this would break much in MyST or elsewhere though? EDIT: MyST seems to not useentitiesat all, and the only use ofAttrDictisenvrelated, so should be removed regardless withmarkdown_it_py>=1.0.0support.