🔧 Update packaging to create unbundled modules#26
Conversation
rowanc1
changed the title
|
@chrisjsewell this is good to go! Have rebased and tested downstream packages (shouldn't be any changes). The references updates look good in vscode. :) |
| * A markdown-it plugin for implementing docutils style roles and directives. | ||
| */ | ||
| export default function docutilsPlugin(md: MarkdownIt, options?: IOptions): void { | ||
| export function docutilsPlugin(md: MarkdownIt, options?: IOptions): void { |
There was a problem hiding this comment.
what was the reason fro this change?
There was a problem hiding this comment.
I was fighting with default exports in jest. This has no changes but allows you to use in jest (default export was undefined)
There was a problem hiding this comment.
ok cheers, perhaps add a comment above export default, that this is required by jest
| * H{sub}`2`O | ||
| * 4{sup}`th` of July | ||
| * {abbr}`CSS (Cascading Style Sheets)` | ||
There was a problem hiding this comment.
we can probably have prettier run against this?
There was a problem hiding this comment.
Yeah, changing these to yaml anyways!
| "include": ["src", "src/directives", "src/roles"], | ||
| "exclude": ["dist", "node_modules", "tests"] | ||
| "include": ["src/**/*"], | ||
| "exclude": [] |
There was a problem hiding this comment.
Does it exclude the those folders by default then?
| "target": "es6", | ||
| "module": "es2015", | ||
| "esModuleInterop": true, | ||
| "noImplicitAny": true, | ||
| "strict": true, | ||
| "moduleResolution": "node", | ||
| "sourceMap": true, | ||
| "outDir": "dist/types", | ||
| "baseUrl": "src", | ||
| "paths": { | ||
| "*": ["node_modules/*"] | ||
| }, | ||
| "typeRoots": ["./node_modules/@types", "./types", "../../node_modules/@types"], | ||
| "resolveJsonModule": true, | ||
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true |
There was a problem hiding this comment.
can you keep the comments for these, or add your own, just to explain what these variables are and/or why the particular settings were chosen.
Just so people can learn from your pain lol
There was a problem hiding this comment.
The default comments were just what you get when you hovered over the variable. Added some other notes back in.
rowanc1
force-pushed
the
feat/packaging
branch
from
8a8bc73 to
88acbe0
Compare
chrisjsewell
changed the title
2 participants
This improves the packaging export to allow for tree-shaking in down stream packages. Bundles are at the top,
Downstream testing:
The new
distfolder looks like: