Merged
Conversation
Member
|
This obviously ties in to executablebooks/markdown-it-amsmath#3, i.e. I think here there needs to be a consistent way to have this math rendered by e.g. katex, within the markdown-it parse/render process |
Member
Author
|
This will need another pass to reconcile with the labeling and the inline math renderer. Once we get it in, can do another pass on that before releasing. |
Member
Author
|
Let's get this in, we can do any reconciliation with other math nodes later, the only change would be to the options which is in another branch. |
chrisjsewell
previously requested changes
Nov 12, 2021
Member
chrisjsewell
left a comment
There was a problem hiding this comment.
Again this just needs fixing of the merge conflict
* Better typing for options
chrisjsewell
requested changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a math directive:
Development:
Leaving out of this PR: