♻️ REFACTOR: Simplify render interface#6
Merged
chrisjsewell merged 2 commits intomainfrom Sep 10, 2021
Merged
Conversation
Member
|
If you can then create a similar PR on markdown-it-dollarmath thanks |
Member
|
and again we should probably mirror the render options for dollarmath/amsmath on the Python side. |
Member
Author
|
I will create a PR on Because these changes are on the renderer side and making those options simpler, I don't actually think that there are any changes to make on the python packages for these. Happy to be corrected! |
chrisjsewell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5
Removes the unnecessary (and somewhat confusing) options from the package, allowing future passing of other arguments if we choose, or a different signature for the renderer (multiple arguments, etc.). The readme is updated to explicitly clarify that the options passed in are katex's not anything to do with this package.
This also ran prettier on the html and md.