👌 Change non-fatal directive parsing errors to warnings#682
👌 Change non-fatal directive parsing errors to warnings#682chrisjsewell merged 2 commits intomasterfrom
Conversation
For non-fatal errors, such as faulty options syntax, unknown option keys, and invalid option values, a warning is raised, but the directive is still run (without the erroneous options). The warning is given the `myst.directive_parse` type, which can be suppressed.
Codecov ReportBase: 89.84% // Head: 90.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 89.84% 90.17% +0.33%
==========================================
Files 23 23
Lines 2560 2586 +26
==========================================
+ Hits 2300 2332 +32
+ Misses 260 254 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Very much want to see this in the JS side as well, it is a bit too strict. |
|
I only looked at the tests, but this seems like a great addition to me 👍. I will follow suit in the JS side soon! |
yep exactly, I know we talked about this Either in this PR or a follow, was going to add changing unknown directives and roles to a warning, with a certain warning type |
|
Awesome, can you tag me so I can make the JS one the same! |
+1 from me |
For non-fatal errors, such as;
faulty options syntax, unknown option keys, and invalid option values,
a warning is raised, but the directive is still run (without the erroneous options).
The warning is given the
myst.directive_parsetype, which can be suppressed.