-
Notifications
You must be signed in to change notification settings - Fork 245
build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.11 #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.11 #1806
Conversation
|
Warning Rate limit exceeded@gupadhyaya has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 31 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe change involves updating the Changes
Sequence Diagram(s)sequenceDiagram
participant A as Application
participant B as CometBFT Library
participant C as Validator Management
A->>B: Request functionality
B-->>A: Provide response
A->>C: Manage validators
C-->>A: Return updated validator set
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Manav-Aggarwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to manually fix serialization tests
Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.38.7 to 0.38.11. - [Release notes](https://github.com/cometbft/cometbft/releases) - [Changelog](https://github.com/cometbft/cometbft/blob/v0.38.11/CHANGELOG.md) - [Commits](cometbft/cometbft@v0.38.7...v0.38.11) --- updated-dependencies: - dependency-name: github.com/cometbft/cometbft dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
73a672e to
b4a0b42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (1)
- go.mod (1 hunks)
Additional comments not posted (1)
go.mod (1)
11-11: LGTM! But verify compatibility.The dependency
github.com/cometbft/cometbfthas been updated fromv0.38.7tov0.38.11. Ensure that the new version does not introduce any breaking changes or incompatibilities.The code changes are approved.
Run the following script to verify the compatibility of the new version:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- types/serialization_test.go (2 hunks)
Additional comments not posted (2)
types/serialization_test.go (2)
54-54: LGTM!The addition of the
VotingPowerfield to theValidatorinstancevalidator1is appropriate and necessary for the consensus mechanism.The code changes are approved.
65-69: LGTM!Using the
cmtypes.NewValidatorSetfunction to construct theValidatorsfield in theSignedHeaderstruct improves encapsulation and initialization.The code changes are approved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
- Coverage 43.89% 43.84% -0.05%
==========================================
Files 76 76
Lines 10028 10028
==========================================
- Hits 4402 4397 -5
- Misses 4893 4897 +4
- Partials 733 734 +1 ☔ View full report in Codecov by Sentry. |
Bumps github.com/cometbft/cometbft from 0.38.7 to 0.38.11.
Release notes
Sourced from github.com/cometbft/cometbft's releases.
Changelog
Sourced from github.com/cometbft/cometbft's changelog.
... (truncated)
Commits
e1b4453v0.38.11 (#3684)66a0447build(deps): Bump docker/build-push-action from 6.5.0 to 6.6.1 (#3676)cd3519dbuild(deps): Bump bufbuild/buf-setup-action from 1.35.1 to 1.36.0 (#3675)c17d1f6fix(types): Only require extension signature if extensions are enabled (#3565)f85d897feat(mempool): add error ErrRecheckFull (backport #3654) (#3656)9de925cfix(e2e): replace docker-compose w/ docker compose (backport #3614) (#3616)e9bd8a9build(deps): Bump docker/setup-buildx-action from 3.5.0 to 3.6.1 (#3610)61ca12ebuild(deps): Bump docker/setup-buildx-action from 3.4.0 to 3.5.0 (#3584)cba216abuild(deps): Bump docker/login-action from 3.2.0 to 3.3.0 (#3585)aaf83e9build(deps): Bump docker/build-push-action from 6.4.1 to 6.5.0 (#3586)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit
cometbftlibrary to enhance performance and incorporate potential bug fixes and new features.Validatorstructure with a newVotingPowerfield to improve consensus mechanisms.ValidatorSetfor better management of validators in block serialization and consensus.