fix(executor): nil error is passed as %w to fmt.Errrof

[trungnt1811]

This PR updates the error message in ApplyBlock to prevent passing a nil error with %w to fmt.Errorf. Fixes #1695

Summary by CodeRabbit

• Bug Fixes
  • Improved error message clarity for proposal processing failures.

[coderabbitai]

Walkthrough

The ApplyBlock method in the BlockExecutor class has been updated to improve the clarity and accuracy of its error messages. Specifically, the error message returned when processing a proposal has been revised to be more meaningful and not misleadingly reference a nil error.

Changes

File	Change Summary
state/executor.go	Updated the error message in the ApplyBlock method to remove the %w format specifier and clarify the error description.

Assessment against linked issues

Objective	Addressed	Explanation
Fix bug where nil error is passed as %w to fmt.Errorf (#1695)	✅

Poem

In the code where blocks do flow,
An error message had to go,
Clearer words now take its place,
No more nil in error's face.
Rollkit's code now shines so bright,
Bugs addressed, all feels right.
🌟🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b4cb7b1 and 9be558e.

Files selected for processing (1)

• state/executor.go (1 hunks)

Additional context used

golangci-lint

Additional comments not posted (1)

state/executor.go (1)

212-212: Updated error message improves clarity and correctness by removing unnecessary error wrapping.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (c9d8467) to head (52a1f09).
Report is 113 commits behind head on main.

Files	Patch %	Lines
state/executor.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   50.23%   42.08%   -8.16%     
==========================================
  Files          52       72      +20     
  Lines        6762     9654    +2892     
==========================================
+ Hits         3397     4063     +666     
- Misses       3024     4921    +1897     
- Partials      341      670     +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tuxcanfly]

OK.