Skip to content

build: update x/net, libp2p and quic #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tzdybal merged 4 commits into from
Apr 26, 2024
Merged

build: update x/net, libp2p and quic #1646

tzdybal merged 4 commits into from
Apr 26, 2024

Conversation

@tzdybal
Copy link
Member

@tzdybal tzdybal commented Apr 25, 2024 •
edited by coderabbitai bot
Loading

Overview

This PR updates dependencies and bumps go version used in CI.

Replaces #1617, #1624.

Summary by CodeRabbit

  • Documentation
    • Updated the Go version requirement in the README to reflect compatibility changes.
  • Chores
    • Updated the Go version in the CI workflow to ensure consistent performance and compatibility.

@tzdybal tzdybal self-assigned this Apr 25, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 25, 2024 •
edited
Loading

Walkthrough

This update involves a version bump for Go from 1.21 to 1.22 in both the continuous integration workflow and the README documentation. The change ensures that the rollkit framework remains compatible with the latest version of Go, reflecting the necessary adjustments in the project's setup and usage guidelines.

Changes

File Change Summary
.github/workflows/.../ci_release.yml Updated Go version from "1.21" to "1.22" in CI workflow configuration.
README.md Updated Go version requirement from 1.21 to 1.22 for rollkit.

🐇✨
A hop in version, a giant leap in code,
From 1.21 to 22, we update the abode.
With each new line, the framework does grow,
Under moonlit skies, our codebase does glow.
🌟📜🌙

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 14690f9 and 85fcafd.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • .github/workflows/ci_release.yml (1 hunks)
  • README.md (1 hunks)
Additional Context Used
LanguageTool (36)
README.md (36)

Near line 1: Possible spelling mistake found.
Context: # Rollkit A modular framework for rollups, with ...

Near line 3: Possible spelling mistake found.
Context: # Rollkit A modular framework for rollups, with an ABCI-compatible client interfa...

Near line 3: Possible spelling mistake found.
Context: ... modular framework for rollups, with an ABCI-compatible client interface. For more in-depth inf...

Near line 3: Possible spelling mistake found.
Context: ...ce. For more in-depth information about Rollkit, please visit our [website][docs]. <!-...

Near line 6: Possible spelling mistake found.
Context: ...kit/rollkit/actions/workflows/test.yml) [![golangci-lint](https://github.com/rollkit/rollkit/act...

Near line 8: Possible spelling mistake found.
Context: ....com/report/github.com/rollkit/rollkit) [![codecov](https://codecov.io/gh/rollkit/rollkit/...

Near line 13: Possible typo: you repeated a word
Context: ...markdownlint-enable MD013 --> ## Using Rollkit ### Rollkit CLI The easiest way to use rollkit is ...

Near line 16: Possible spelling mistake found.
Context: ...### Rollkit CLI The easiest way to use rollkit is via the rollkit CLI. Requires Go ve...

Near line 16: Possible spelling mistake found.
Context: ...e easiest way to use rollkit is via the rollkit CLI. Requires Go version >= 1.22. A c...

Near line 20: Possible spelling mistake found.
Context: ...t CLI. Requires Go version >= 1.22. A cli tool that allows you to run different k...

Near line 20: Possible spelling mistake found.
Context: ...u to run different kinds of nodes for a rollkit network while also helping you generate...

Near line 25: Possible spelling mistake found.
Context: ...uration files #### Install To install rollkit, simply run the following command at t...

Near line 25: Possible spelling mistake found.
Context: ...he following command at the root of the rollkit repo bash make install The lat...

Near line 32: Possible spelling mistake found.
Context: ...o bash make install The latest Rollkit is now installed. You can verify the in...

Near line 40: Possible spelling mistake found.
Context: ...## Quick Start You can spin up a local rollkit network with the following command: ``...

Near line 46: Unpaired symbol: ‘]’ seems to be missing
Context: ...tart ``` Explore the CLI documentation here ##...

Near line 66: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 3337 characters long)
Context: ... way to find something you can help with! See [the contributing guide](https://g...

Near line 95: Unpaired symbol: ‘]’ seems to be missing
Context: ... proto-lint ``` ### Tools 1. Install [golangci-lint](https://golangci-lint.run...

Near line 95: Possible spelling mistake found.
Context: ...proto-lint ``` ### Tools 1. Install [golangci-lint](https://golangci-lint.run/welcome/inst...

Near line 96: Unpaired symbol: ‘]’ seems to be missing
Context: ...i-lint.run/welcome/install/) 1. Install [markdownlint](https://github.com/DavidAn...

Near line 96: Possible spelling mistake found.
Context: ...-lint.run/welcome/install/) 1. Install [markdownlint](https://github.com/DavidAnson/markdown...

Near line 97: Unpaired symbol: ‘]’ seems to be missing
Context: ...com/DavidAnson/markdownlint) 1. Install [hadolint](https://github.com/hadolint/ha...

Near line 97: Possible spelling mistake found.
Context: ...om/DavidAnson/markdownlint) 1. Install hadolint ...

Near line 98: Unpaired symbol: ‘]’ seems to be missing
Context: ...ithub.com/hadolint/hadolint) 1. Install [yamllint](https://yamllint.readthedocs.i...

Near line 98: Possible spelling mistake found.
Context: ...thub.com/hadolint/hadolint) 1. Install [yamllint](https://yamllint.readthedocs.io/en/sta...

Near line 102: Possible spelling mistake found.
Context: ...e our progress and a possible future of Rollkit visit our [Dependency Graph](https://gi...

Near line 107: Possible typo: you repeated a whitespace
Context: ...dependency-graph.md). ## Audits | Date | Auditor ...

Near line 107: Possible typo: you repeated a whitespace
Context: ....md). ## Audits | Date | Auditor | Version ...

Near line 107: Possible typo: you repeated a whitespace
Context: ... | Version | Report ...

Near line 107: Possible typo: you repeated a whitespace
Context: ... | Report | |------------|------------------------...

Near line 109: Possible typo: you repeated a whitespace
Context: ...--------------------------| | 2024/01/12 | [Informal Systems](https://informal.sy...

Near line 109: Possible spelling mistake found.
Context: ... Systems](https://informal.systems/) | [eccdd...bcb9d](https://github.com/rollkit/rol...

Near line 109: Possible typo: you repeated a whitespace
Context: ...ccdd0f1793a5ac532011ef4d896de9e0d8bcb9d) | [informal-systems.pdf](specs/audit/inf...

Near line 110: Possible typo: you repeated a whitespace
Context: ...nary Builders](https://binary.builders/) | [eccdd...bcb9d](https://github.com/rol...

Near line 110: Possible spelling mistake found.
Context: ...uilders](https://binary.builders/) | [eccdd...bcb9d](https://github.com/rollkit/rol...

Near line 110: Possible typo: you repeated a whitespace
Context: ...rs.pdf](specs/audit/binary-builders.pdf) | [docs]: https://rollkit.dev

Additional comments not posted (2)
README.md (1)

18-18: Update Go version requirement to 1.22.

This change correctly updates the Go version requirement in the documentation, ensuring users are aware of the new version needed to use Rollkit.

.github/workflows/ci_release.yml (1)

30-30: Update Go version to 1.22 in CI workflow.

This change correctly updates the Go version in the CI workflow, ensuring that the CI processes use the latest Go version for compatibility and leveraging new features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tzdybal tzdybal mentioned this pull request Apr 25, 2024
Closed
@tzdybal tzdybal changed the title deps: update x/net, libp2p and quic build: update x/net, libp2p and quic Apr 25, 2024
@tzdybal tzdybal enabled auto-merge April 25, 2024 20:36
@tzdybal tzdybal requested a review from MSevey April 25, 2024 20:36
@tzdybal tzdybal added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 7c854db Apr 26, 2024
@tzdybal tzdybal deleted the tzdybal/quic-update branch April 26, 2024 14:26
@tac0turtle tac0turtle removed this from Evolve Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gupadhyaya gupadhyaya gupadhyaya approved these changes

@Manav-Aggarwal Manav-Aggarwal Awaiting requested review from Manav-Aggarwal

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

+1 more reviewer

@MSevey MSevey MSevey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tzdybal tzdybal

Labels

T:dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tzdybal @gupadhyaya @MSevey