test: test P2P catchup

[tzdybal]

Overview

Resolves #1213.

Summary by CodeRabbit

• Tests
  • Added doTestCatchup function to ensure the system can catch up with a specified number of blocks during integration tests.

[coderabbitai]

Walkthrough

The doTestCatchup function has been integrated into node/full_node_integration_test.go to evaluate the ability of a full node to catch up when it lags behind. This function establishes nodes with a mock Data Availability (DA) client, submits transactions, and waits for a set number of blocks to be created.

Changes

File	Change Summary
node/full_node_integration_test.go	Added doTestCatchup function to test node synchronization with specific block counts.

Sequence Diagram(s)

sequenceDiagram
    participant Tester
    participant Node
    participant DAClient
    participant BlockProducer
    
    Tester->>Node: Initialize nodes with DAClient
    Node->>DAClient: Connect mock DA Client
    Tester->>Node: Submit transactions
    Node->>BlockProducer: Wait for block production
    BlockProducer->>Node: Produce specified number of blocks
    Node->>Tester: Completion of block synchronization

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ensure full node catches up when far behind with many transactions (#1213)	✅

Poem

In the code, nodes sync anew,
Transactions flow, blocks catchup too.
Mock DA hummed, code aligned,
Full nodes leapt, never left behind.
In test arrays, sync times through.

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 196c419 and 05190e4.

Files selected for processing (1)

• node/full_node_integration_test.go (1 hunks)

Additional comments not posted (1)

node/full_node_integration_test.go (1)

708-728: Good structure for testing catch-up scenarios.

The function TestCatchUp is well-structured, testing both small and large catch-up scenarios. Ensure that edge cases, such as network failures or data corruption, are also tested to cover all possible scenarios.

[Manav-Aggarwal]

LGTM