Minimize Tendermint dependencies

[tzdybal]

Because Optimint is a "drop-in replacement" of Tendermint, we should minimize dependencies on Tendermint (lazyledger-core) packages.

All dependencies cannot be eliminated, because structs/interfaces are used in common API.

Easiest way of eliminating dependencies is to copy code into optimint repository.

[liamsi]

is this still relevant?

[tzdybal]

Not sure TBH. Probably we should re-assess this.

[tzdybal]

Issues:

1. types are everywhere ;) There are github.com/tendermint/tendermint/abci/types (generated from protobuf), github.com/tendermint/tendermint/types (hand crafted, with extra functionalities), github.com/tendermint/tendermint/proto/... (generated from protobuf). In many places they are mixed (tendermint/tendermint/types use tendermint/tendermint/proto/types, etc).
2. All the types are structs, not interfaces - it's hard to substitute types.
3. Optimint is connected to cosmos-sdk app as a library, any many arguments use types from github.com/tendermint/tendermint. There's no extra protobuf serialization, to let us use "same" types (copied/regenerated).
4. Optimint still use some "hand crafted" types to access extra logic.

[tzdybal]

OMG, I just found pre-historic browser tab with following comment that was not submitted for many months 🤦

Issues:

1. types are everywhere ;) There are github.com/tendermint/tendermint/abci/types (generated from protobuf), github.com/tendermint/tendermint/types (hand crafted, with extra functionalities), github.com/tendermint/tendermint/proto/... (generated from protobuf). In many places they are mixed (tendermint/tendermint/types use tendermint/tendermint/proto/types, etc).
2. All the types are structs, not interfaces - it's hard to substitute types.
3. Optimint is connected to cosmos-sdk app as a library, any many arguments use types from github.com/tendermint/tendermint. There's no extra protobuf serialization, to let us use "same" types (copied/regenerated).
4. Optimint still use some "hand crafted" types to access extra logic.