Feature/i14 fiddles crud #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Travis |
joshghent
reviewed
Jul 1, 2019
Contributor
There was a problem hiding this comment.
Amazing work! Thanks for writing tests and docs too! That's great. Thanks very much for your help. You're definitely along the right track. Yes I was going to use either Oauth or perhaps better yet to use Auth0? To start with I was going to use just standard JWT. I think making sure we can authenticate with microservices is most important
With regards to the branches, because this API is not complete yet, there is no "dev" as such. So yeah PR's against master are fine for now until we release 👍
joshghent
approved these changes
Jul 1, 2019
Contributor
Author
|
Right on. Thanks @joshghent! I'll continue working on issue #14 and see if I can get authentication up and running using JWT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - #14
Adds:
Let me know if I'm on the right track here and I'll try to continue adding stuff. Was thinking OAuth would be next.
Also, you don't seem to have a "dev" type branch for me to PR into so I just did master...