refactor(storage/bloom): remove bloomfilter dependency
#3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And inline the subset of its functionality we use, plus some internals that have not been made public on the `bloomfilter` API.
Now that it's unused.
t00ts
approved these changes
Jan 6, 2026
Contributor
t00ts
left a comment
t00ts
left a comment
There was a problem hiding this comment.
LGTM
I suppose this new approach is implicitly covered by existing tests (otherwise, should we consider adding a test?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using only a small subset of the functionality provided by the
bloomfiltercrate and were relying on some of the internals (like the layout of the internal bit vector).To avoid being stuck forever with
bloomfilter1.x this PR removes our dependency on thebloomfiltercrate and instead reimplements the functionality we actually use.We can now also compute the Bloom filter bit indices much more efficiently -- the
bloomfiltercrate did not have an API for that, so we had to rely on an ugly, inefficient hack to get that piece of information.