refactor(consensus/storage): merge consensus db into main one #3070
Conversation
| ); | ||
|
|
||
| let fake_proposals_storage = fake_proposals_storage.clone(); | ||
| let fake_proposals_storage = storage.clone(); |
There was a problem hiding this comment.
This appears to work, but @CHr15F0x has been complaining that making proposals from the main DB is problematic (AFAIK because the state diffs have to be stored only after the proposal is accepted by consensus, and computing them before that, i.e. here, interferes with that). Has that been solved?
There was a problem hiding this comment.
+1, i don't remember exactly but unless we have a decently working real proposal creation algo I'd keep this PR/issue parked. Currently using the prod db as a scratchpad for fake proposal creation seems fishy.
| @@ -0,0 +1,19 @@ | |||
| use anyhow::Context; | |||
|
|
|||
| pub(crate) fn migrate(tx: &rusqlite::Transaction<'_>) -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
This certainly works, but @kkovaacs was concerned about tying the P2P-specific tables to the main DB, and consequently to releases (major version for each DB change).
There was a problem hiding this comment.
Indeed. I think our consensus implementation is still too much in flux to have that in our 'main' DB. If we use the 'main' DB for consensus then pretty much every release we do will have to be a 'breaking' release and each and every change in consensus will require a migration.
| tracing::info!("Creating consensus proposals table"); | ||
|
|
||
| tx.execute( | ||
| r"CREATE TABLE IF NOT EXISTS consensus_proposals ( |
There was a problem hiding this comment.
I suppose IF NOT EXISTS is unnecessary here - but that's just a detail...
Closes #3047.