Add helper util do determine whether a price is variable#261
Merged
Conversation
jnmau
requested review from
alexmarqs,
chemic,
Copilot,
josecarneiro and
paulofph
paulofph
approved these changes
Mar 11, 2026
alexmarqs
reviewed
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable Price Determination
A price is determined to be variable if any of the following conditions are met.
per_unitvariable_price === truetiered_volumetiered_graduatedtiered_flatfeedynamic_tariffexternal_getagget_ag.type === 'work_price'external_getagget_ag.type === 'base_price'ANDget_ag.markup_pricing_model === 'tiered_flatfee'Why
The
variable_priceboolean onPriceentities is unreliable — it can betruewhen a price isn't actually variable, orfalsewhen it is.isVariablePricereplaces these checks with deterministic logic based onpricing_modeland related fields. This ensures price mappings are only applied when the price truly requires variable input.