Add symbol kind and structured flags to diff proto output#337
Open
Add symbol kind and structured flags to diff proto output#337
Conversation
Expose SymbolKind (Function, Object, Section, Unknown) in the DiffSymbol proto message, allowing CLI oneshot diff consumers to distinguish symbol types without inferring from instruction/data presence.
…essage Remove the symbol filter (size == 0 / Ignored) from DiffObject so all symbols are emitted. This fixes target_symbol indices being invalid after filtering. Replace the DiffSymbolFlag bitmask enum + uint32 field with a DiffSymbolFlags message of booleans, adding ignored and size_inferred flags so consumers can filter on their end.
encounter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffSymbolKindenum (SYMBOL_UNKNOWN,SYMBOL_FUNCTION,SYMBOL_OBJECT,SYMBOL_SECTION) andkindfield toDiffSymbolDiffSymbolFlagbitmask enum +uint32 flagswith aDiffSymbolFlagsmessage of booleans (global,local,weak,common,hidden,ignored,size_inferred)DiffObject::new()— all symbols are now included in the output, fixingtarget_symbolindices being invalid after filteringsize,kind, andflags.ignoredMotivation
DiffSymbol.target_symbolandDiffRelocation.target_symbolemitted raw indices into the unfilteredObject.symbolsarray, but the output'ssymbolsarray was filtered (skippingsize == 0andIgnoredsymbols). This made the indices unusable for consumers.Rather than remapping indices, we include all symbols and give consumers enough metadata to filter on their end.