Skip to content

WRP-28251: Create documentation for dynamic color mode#208

Merged
adrian-cocoara-lgp merged 4 commits intofeature/WRP-26847from
feature/WRP-28251
Sep 29, 2023
Merged

WRP-28251: Create documentation for dynamic color mode#208
adrian-cocoara-lgp merged 4 commits intofeature/WRP-26847from
feature/WRP-28251

Conversation

@stanca-pop-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Custom colors sample needs documentation.

Resolution

Added jsdocs, comments within the code and a readme file.

Additional Considerations

Links

WRP-28251

Comments

Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com

@adrian-cocoara-lgp
Copy link
Contributor

adrian-cocoara-lgp commented Sep 28, 2023

The comments ans JSDocs you've added look good to me, but we need to keep this PR on hold until travis fail is fixed

Since we merge this PR into feature/WRP-26847, we can fix travis fain in that PR

Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adrian-cocoara-lgp adrian-cocoara-lgp merged commit bea167b into feature/WRP-26847 Sep 29, 2023
@adrian-cocoara-lgp adrian-cocoara-lgp deleted the feature/WRP-28251 branch September 29, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants