Use 'set filetype' to set filetype once again #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The s:setf() helper function was originally introduced to avoid setting the filetype multiple times (375e9e1). I believe this covered the case where a file had an .ex or .exs extension and also include "elixir" in the shebang line (such that s:DetectElixir() would match and call 'set filetype' redundantly). c56bd82 removed the existing &filetype check in s:setf(), relying on the &filetype global and ftdetect framework to avoid redundant updates. I believe we can simplify this even further by using just 'set filetype' in the file extension-based autocommands and including a guard against (re)setting filetype in s:DetectElixir(). Also, use explicit case-insensitive comparison operators. This isn't a good place to make assumptions about 'ignorecase'.
Collaborator
|
Sorry for the delay on this. Must've missed it during the holidays |
kelvinst
pushed a commit
to kelvinst/vim-elixir
that referenced
this pull request
Aug 21, 2019
The s:setf() helper function was originally introduced to avoid setting the filetype multiple times (375e9e1). I believe this covered the case where a file had an .ex or .exs extension and also include "elixir" in the shebang line (such that s:DetectElixir() would match and call 'set filetype' redundantly). c56bd82 removed the existing &filetype check in s:setf(), relying on the &filetype global and ftdetect framework to avoid redundant updates. I believe we can simplify this even further by using just 'set filetype' in the file extension-based autocommands and including a guard against (re)setting filetype in s:DetectElixir(). Also, use explicit case-insensitive comparison operators. This isn't a good place to make assumptions about 'ignorecase'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
s:setf()helper function was originally introduced to avoid setting the filetype multiple times (375e9e1). I believe this covered the case where a file had an.exor.exsextension and also include "elixir" in the shebang line (such thats:DetectElixir()would match and callset filetyperedundantly).c56bd82 removed the existing
&filetypecheck ins:setf(), relying on the&filetypeglobal and ftdetect framework to avoid redundant updates.I believe we can simplify this even further by using just
set filetypein the file extension-based autocommands and including a guard against (re)setting filetype ins:DetectElixir().Also, use explicit case-insensitive comparison operators. This isn't a good place to make assumptions about
ignorecase.