Skip to content

feat: Use the new @eik/common-config-loader module #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trygve-lie merged 1 commit into from
Aug 18, 2022
Merged

feat: Use the new @eik/common-config-loader module #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"homepage": "https://github.com/eik-lib/node-client#readme",
"dependencies": {
"@eik/common": "3.0.1",
"@eik/common-config-loader": "4.0.0-next.8",
"abslog": "2.4.0",
"undici": "5.8.0"
},
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { helpers } from '@eik/common';
import { request } from 'undici';
import { join } from 'path';
import loader from '@eik/common-config-loader';
import Asset from './asset.js';

const trimSlash = (value = '') => {
Expand Down Expand Up @@ -55,7 +55,7 @@ export default class NodeClient {
}

async load() {
this.#config = await helpers.getDefaults(this.#path);
this.#config = await loader.getDefaults(this.#path);
if (this.#loadMaps) {
this.#maps = await fetchImportMaps(this.#config.map);
}
Expand Down
4 changes: 2 additions & 2 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { mkdtemp, writeFile } from 'fs/promises';
import { helpers } from '@eik/common';
import loader from '@eik/common-config-loader';
import path from 'path';
import http from 'http';
import tap from 'tap';
Expand All @@ -8,7 +8,7 @@ import os from 'os';
import NodeClient from '../src/index.js';

const FIXTURE_PATH = `${process.cwd()}/fixtures`;
const FIXTURE_FILE = await helpers.getDefaults(FIXTURE_PATH);
const FIXTURE_FILE = await loader.getDefaults(FIXTURE_PATH);

const writeTempConfig = async (address) => {
const pathname = await mkdtemp(path.join(os.tmpdir(), `eik-${address.port.toString()}-`));
Expand Down