feat: add alias command as an eventual replacement for the 3 existing alias commands#572
Merged
digitalsadhu merged 3 commits intonextfrom Aug 4, 2024
Merged
feat: add alias command as an eventual replacement for the 3 existing alias commands#572digitalsadhu merged 3 commits intonextfrom
digitalsadhu merged 3 commits intonextfrom
Conversation
… alias commands This is a non breaking change but does add deprecation messages for pkg-alias, map-alias and npm-alias, all of which are replaced by this new alias command. The alias command detects type from eik.json which was not possible in earlier versions of the cli which was the reason for the existence of 3 separate commands instead of 1. If the command is run in a directory that does not contain an eik.json file, type can be provided via the command line argument --type. If neither are present, an error is thrown.
digitalsadhu
requested review from
flatoy,
leftieFriele,
tor0405,
trygve-lie and
wkillerud
leftieFriele
approved these changes
Aug 2, 2024
Contributor
leftieFriele
left a comment
leftieFriele
left a comment
There was a problem hiding this comment.
🌮 huge win doing this. much easier to grasp what's going on with Alias commands with just this one.
Co-authored-by: William Killerud <william@killerud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a non breaking change but does add deprecation messages for pkg-alias, map-alias and npm-alias, all of which are replaced by this new alias command.
The alias command detects type from eik.json which was not possible in earlier versions of the cli which was the reason for the existence of 3 separate commands instead of 1. If the command is run in a directory that does not contain an eik.json file, type can be provided via the command line argument --type. If neither are present, an error is thrown.
There is some formatting of command messages thrown in for good measure with this PR.