Skip to content

De register nodes for nats controller on lookup #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sleipnir merged 2 commits into from
Dec 22, 2024
Merged

De register nodes for nats controller on lookup #398

sleipnir merged 2 commits into from
Dec 22, 2024

Conversation

@eliasdarruda
Copy link
Collaborator

@eliasdarruda eliasdarruda commented Dec 22, 2024 •
edited
Loading

  • handle exit signals better
  • make sure we avoid keeping dead nodes in register

@sleipnir sleipnir merged commit 67e83d9 into main Dec 22, 2024
1 check passed
@sleipnir sleipnir deleted the deregister-on-nats branch December 22, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sleipnir sleipnir sleipnir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliasdarruda @sleipnir