Conversation
eht16
reviewed
Apr 10, 2022
eht16
reviewed
Apr 10, 2022
eht16
reviewed
Apr 10, 2022
eht16
requested changes
Apr 10, 2022
Owner
eht16
left a comment
eht16
left a comment
There was a problem hiding this comment.
Great, thank you!
I have just a couple of minor comments.
And could you have a look at the code style, basically PEP8 + 100 charcters line length (see the failed CI for details) or test locally by running tox.
Thanks!
PMazarovich
force-pushed
the
Disk_error_handling
branch
from
b4029e1 to
5b48af8
Compare
Contributor
Author
|
@eht16 requested changes are in place |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once after IO error worker was killed and all events just began to accumulate endlessly.
That is why it is better to handle disk errors to keep worker alive.