Merged
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Dec 1, 2022
Contributor
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
Some comment, WDYT?
|
|
||
| // Contains fails the test if needle is not contained within haystack, if haystack or needle is | ||
| // an empty slice, or if needle is longer than haystack. | ||
| func Contains(tb testing.TB, haystack, needle []string) { |
Contributor
There was a problem hiding this comment.
Shouldn't this be.... generic? ;p
Contributor
There was a problem hiding this comment.
Otherwise, let's use ContainsStringSlice function name?
Collaborator
Author
There was a problem hiding this comment.
You're right! Something generic would suit here. Let me try to tackle that in next PR. Changing name for now! 🙂
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the
Containsmethod from Thanostestutilpackage.