fix: parent icon not reflecting child approval#163
fix: parent icon not reflecting child approval#163rschmukler wants to merge 1 commit intoeditor-code-assistant:masterfrom
Conversation
When a child tool call event fired (e.g. `toolCalled`, `toolCallRunning`, `toolCallRejected`), `eca-chat--update-parent-subagent-status` was called with the loading symbol (⏳), unconditionally overwriting the parent's status. If a sibling child was still pending approval, the parent would incorrectly show ⏳ instead of 🚧. Before applying the loading symbol to a parent, check all child segment overlays. If any child still has `eca-chat--tool-call-status` set to the pending-approval symbol, preserve 🚧 on the parent instead of downgrading to ⏳. This mirrors the existing guard in `eca-chat--tool-call-subagent-details` but applies it consistently in the parent status update path.
|
@rschmukler I did a simpler fix, related to your last PR. Let's please avoid letting LLM change everything and just trust in it. This affects code maintainability, review carefully what it's being changed so we evolve eca safely :) You would see this error in the new eca-emacs-errors buffer: |
|
@ericdallo I agree we should probably message in addition to log it. The bug that you fixed was actually related to the commit we deleted, where unfortunately, neither one of us tested it after I deleted that commit. I don' think it had to do with LLM generated code. I don't believe that this bug is related to that bug so it might be worth looking at this to see whether there is a more to it. |
|
@ericdallo I have hit this again. See the screenshot below:
There is private info in the content of the UI so I had to crop - but as you can see, the There are no errors in the |


Issue
When a child tool call event fired (e.g.
toolCalled,toolCallRunning,toolCallRejected),eca-chat--update-parent-subagent-statuswas called with the loading symbol (⏳), unconditionally overwriting the parent's status. If a sibling child was still pending approval, the parent would incorrectly show ⏳ instead of 🚧.Fix
Before applying the loading symbol to a parent, check all child segment overlays. If any child still has
eca-chat--tool-call-statusset to the pending-approval symbol, preserve 🚧 on the parent instead of downgrading to ⏳. This mirrors the existing guard ineca-chat--tool-call-subagent-detailsbut applies it consistently in the parent status update path.