feat: add serviceId to version object#192
Merged
jimmarino merged 1 commit intoeclipse-dataspace-protocol-base:mainfrom Jun 18, 2025
Merged
feat: add serviceId to version object#192jimmarino merged 1 commit intoeclipse-dataspace-protocol-base:mainfrom
serviceId to version object#192jimmarino merged 1 commit intoeclipse-dataspace-protocol-base:mainfrom
Conversation
jimmarino
approved these changes
Jun 18, 2025
jimmarino
merged commit 84f2a38
into
eclipse-dataspace-protocol-base:main
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds an optional
serviceIdproperty to the version objectWhy it does that
Give clients the ability to correlate different entries in the
protocolVersionsarray by the DataService/Connector they're exposed by.Linked Issue(s)
Closes #146