feat: replace message diagrams with autogenerated tables#111
Merged
juliapampus merged 1 commit intoeclipse-dataspace-protocol-base:mainfrom Feb 6, 2025
Merged
Conversation
juliapampus
approved these changes
Feb 6, 2025
arnoweiss
force-pushed
the
feat/import-property-tables
branch
from
34fad79 to
b6a4254
Compare
juliapampus
requested changes
Feb 6, 2025
Contributor
juliapampus
left a comment
juliapampus
left a comment
There was a problem hiding this comment.
The CN state machine diagram link is broken. This is the only one I could find.
juliapampus
approved these changes
Feb 6, 2025
Contributor
juliapampus
left a comment
juliapampus
left a comment
There was a problem hiding this comment.
Just in time, great :) LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR replaces the figures from the message definitions with autogenerated tables. Preview in the fork: https://arnoweiss.github.io/DataspaceProtocol/
Why it does that
Consistency, avoiding double-maintenance in text and schemas
Linked Issue(s)
Closes #110
Preceeds #82
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.