Adds comments to .properties files to not change port when using in docker container#637
Open
moumenakkad wants to merge 1 commit intoeclipse-basyx:mainfrom
Open
Adds comments to .properties files to not change port when using in docker container#637moumenakkad wants to merge 1 commit intoeclipse-basyx:mainfrom
moumenakkad wants to merge 1 commit intoeclipse-basyx:mainfrom
Conversation
aaronzi
changed the title
aaronzi
requested changes
Feb 20, 2025
Member
aaronzi
left a comment
aaronzi
left a comment
There was a problem hiding this comment.
Thanks for the adjustments of the .properties files. Just a minor remark/question: What do you mean by "The port should only by changed when the application is not running"? I think this last sentence could say something like: "This port should only be changed when running the application without Docker".
aaronzi
requested changes
Feb 20, 2025
aaronzi
requested changes
Feb 27, 2025
Member
aaronzi
left a comment
aaronzi
left a comment
There was a problem hiding this comment.
Please also merge origin/main from the remote repository into your branches. There were recent changes in the main branch that will require minimal adaptions in your PR
Member
There was a problem hiding this comment.
Please remove this change. This is in a test
Member
There was a problem hiding this comment.
This change should be removed since this is not an application settings file but a docker-compose file. Here the external port can actually be changed
Comment on lines
+1
to
+3
| # Do NOT change any port while running in a Docker container. | ||
| # Changing this will make the service unreachable from outside the container. | ||
| # This port should only be changed when running the application without Docker |
Member
There was a problem hiding this comment.
Suggested change
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. | |
| # This port should only be changed when running the application without Docker | |
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. |
Comment on lines
+1
to
+3
| # Do NOT change any port while running in a Docker container. | ||
| # Changing this will make the service unreachable from outside the container. | ||
| # This port should only be changed when running the application without Docker |
Member
There was a problem hiding this comment.
Suggested change
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. | |
| # This port should only be changed when running the application without Docker | |
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. |
Comment on lines
+1
to
+3
| # Do NOT change any port while running in a Docker container. | ||
| # Changing this will make the service unreachable from outside the container. | ||
| # This port should only be changed when running the application without Docker |
Member
There was a problem hiding this comment.
Suggested change
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. | |
| # This port should only be changed when running the application without Docker | |
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. |
Comment on lines
+1
to
+3
| # Do NOT change any port while running in a Docker container. | ||
| # Changing this will make the service unreachable from outside the container. | ||
| # This port should only be changed when running the application without Docker |
Member
There was a problem hiding this comment.
Suggested change
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. | |
| # This port should only be changed when running the application without Docker | |
| # Do NOT change any port while running in a Docker container. | |
| # Changing this will make the service unreachable from outside the container. |
moumenakkad
force-pushed
the
fix-issue-411
branch
from
852f85d to
0ed075d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All .properties files were modified. A comment was added to ensure user is warned about changing port while docker is running, as specified in rules of issue #411
Closes #411