Skip to content

Update fitters and add test that weights behave as expected#216

Merged
rozyczko merged 2 commits intodevelopfrom
fix-minimizer-weights
Feb 19, 2026
Merged

Update fitters and add test that weights behave as expected#216
rozyczko merged 2 commits intodevelopfrom
fix-minimizer-weights

Conversation

@henrikjacobsenfys
Copy link
Copy Markdown
Member

Closes #204

@henrikjacobsenfys henrikjacobsenfys added this to the version 2.2 milestone Feb 18, 2026
@henrikjacobsenfys henrikjacobsenfys added [scope] bug Bug report or fix (major.minor.PATCH) [area] fitting Umbrella for fitting related work [priority] high Should be prioritized soon labels Feb 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.11%. Comparing base (ed35c99) to head (a99f068).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #216   +/-   ##
========================================
  Coverage    81.11%   81.11%           
========================================
  Files           52       52           
  Lines         4274     4274           
  Branches       740      740           
========================================
  Hits          3467     3467           
  Misses         627      627           
  Partials       180      180           
Flag Coverage Δ
unittests 81.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../easyscience/fitting/minimizers/minimizer_bumps.py 88.97% <100.00%> (ø)
...rc/easyscience/fitting/minimizers/minimizer_dfo.py 92.91% <100.00%> (ø)
.../easyscience/fitting/minimizers/minimizer_lmfit.py 92.17% <100.00%> (ø)

@rozyczko rozyczko merged commit fa8e0a5 into develop Feb 19, 2026
35 checks passed
@rozyczko rozyczko deleted the fix-minimizer-weights branch February 19, 2026 08:17
@damskii9992 damskii9992 linked an issue Feb 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] fitting Umbrella for fitting related work [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lmfit expects 1/sqrt(variance) and Bumps expects sqrt(variance)

2 participants