Changed the behaviour of TableViewTextInput to loose focus on enter/return#35
Open
Changed the behaviour of TableViewTextInput to loose focus on enter/return#35
Conversation
seventil
added
[scope] enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now any TableViewTextInput (and TextInput/TextField in general) based elements rely on Accepted and EditingFinished signals to tie in backend logic. The issue with such an approach is that pressing enter fires both signals, while the focus remains in the element providing no visual feedback to the user that the input was accepted. Moreover, adding 'focus = true' in code might accidentally fire secondary EditingFinished signal.
This PR introduces a way to provide visual feedback to the user on enter/return pressed.
Behaviour of Accepted/EditingFinished is not changed: Accepted is fired on enter/return, EditingFinished is fired on enter/return or focus loss.