Fixed problem in ResultsetTable when sortValue is missing#2082
Merged
jsuarezgonz merged 4 commits intomasterfrom Aug 23, 2024
Merged
Fixed problem in ResultsetTable when sortValue is missing#2082jsuarezgonz merged 4 commits intomasterfrom
jsuarezgonz merged 4 commits intomasterfrom
Conversation
Collaborator
Author
|
I will be adding interaction tests for this scenario to prevent it from happening again. |
jsuarezgonz
requested changes
Aug 23, 2024
Collaborator
jsuarezgonz
left a comment
jsuarezgonz
left a comment
There was a problem hiding this comment.
Please add a functional test to check that the columns are correctly sorted according to 'displayValue' when 'sortValue' is undefined
jsuarezgonz
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Description
SortValue must take displayValue instead if it is undefined. After changing the structure adding the "cells" item, this is not working.