Skip to content

Fix next version #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 2 commits into from
Jul 26, 2024
Merged

Fix next version #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
100c5a6
Fix next version
Mil4n0r Jul 26, 2024
79576f5
Merge branch 'master' into Mil4n0r/fix_nextconfig_release
Jialecl Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/website/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ module.exports = {
return config;
},
reactStrictMode: true,
assetPrefix: process.env.NODE_ENV === "production" ? `/halstack/${process.env.SITE_VERSION}` : undefined,
basePath: process.env.NODE_ENV === "production" ? `/halstack/${process.env.SITE_VERSION}` : undefined,
assetPrefix: process.env.NODE_ENV === "production" ? `/halstack/${process.env.NEXT_PUBLIC_SITE_VERSION}` : undefined,
basePath: process.env.NODE_ENV === "production" ? `/halstack/${process.env.NEXT_PUBLIC_SITE_VERSION}` : undefined,
transpilePackages: [
"@cloudscape-design/components",
"@cloudscape-design/component-toolkit",
Expand Down
8 changes: 4 additions & 4 deletions apps/website/screens/principles/typography/code/TypographyCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ const sections = [
title: "Examples",
subSections: [
{
title: "Heading",
title: "Heading basic usage",
content: <Example example={headingBasicUsage} defaultIsVisible />,
},
{
title: "Paragraph",
title: "Paragraph basic usage",
content: <Example example={paragraphBasicUsage} defaultIsVisible />,
},
{
title: "Bulleted list",
title: "Bulleted list basic usage",
content: <Example example={bulletedListBasicUsage} defaultIsVisible />,
},
{
title: "Typography",
title: "Typography basic usage",
content: <Example example={typographyBasicUsage} defaultIsVisible />,
},
],
Expand Down
2 changes: 1 addition & 1 deletion scripts/release-website.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const buildSite = (version) => {
return new Promise((resolve, reject) => {
console.log(`Building site with version ${version}`);
exec(
`cd apps/website && SITE_VERSION=${version} npm run build`,
`cd apps/website && NEXT_PUBLIC_SITE_VERSION=${version} npm run build`,
(error, stdout, stderr) => {
if (error) {
throw new Error(error.message);
Expand Down