Skip to content

Added tooltip visual tests to components that internally use them#2045

Merged
GomezIvann merged 2 commits intomasterfrom
Mil4n0r/added_tooltip_tests
Aug 6, 2024
Merged

Added tooltip visual tests to components that internally use them#2045
GomezIvann merged 2 commits intomasterfrom
Mil4n0r/added_tooltip_tests

Conversation

@Mil4n0r
Copy link
Copy Markdown
Collaborator

@Mil4n0r Mil4n0r commented Jul 23, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Stories added to the following components (the ones that internally use DxcTooltip in any of their parts:

  • ActionIcon
  • Badge
  • Button
  • DateInput
  • Footer
  • Header
  • ApplicationLayout
  • Select

Additional context
I have also a mechanism to protect against having multiple nested Tooltips overlapping, so I am covering this scenario in the tests and have added some logic to DxcTooltip component (only allowing the highest level tooltip to be displayed).

Closes #2044

@GomezIvann GomezIvann self-requested a review August 2, 2024 07:27
@GomezIvann GomezIvann self-assigned this Aug 2, 2024
@GomezIvann GomezIvann merged commit 4e8b687 into master Aug 6, 2024
@GomezIvann GomezIvann deleted the Mil4n0r/added_tooltip_tests branch August 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing tests for tooltip interactions with current components

2 participants