Merged
Conversation
GomezIvann
suggested changes
Jul 17, 2024
Collaborator
Author
|
I have yet to ask for the specs image with the 2px padding added. |
…y/halstack-react into Mil4n0r/link_border-radius
…y/halstack-react into Mil4n0r/link_border-radius
Collaborator
Author
|
All images have been updated. |
Mil4n0r
commented
Jul 29, 2024
GomezIvann
reviewed
Aug 2, 2024
…o Mil4n0r/link_border-radius
…y/halstack-react into Mil4n0r/link_border-radius
Collaborator
Author
I missed that, but I agree with you that it is too tall. Using 100% line-height for the anchor seems to look just like in the images. |
GomezIvann
suggested changes
Aug 9, 2024
GomezIvann
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Description
For consistency purposes, the border-radius of the Link component is 2px and we want to update it to 4px. This is its value in most of our components.
Additional context
Even though it was listed as 2px, the images used were using
border-radius: 4pxinternally. That is why it is only required to change the first image in the Specifications tab.Closes #1719