Allow placing aliases in a separate file#2
Merged
dwaring87 merged 1 commit intodwaring87:masterfrom Feb 11, 2018
Merged
Conversation
…source control independent of the private user data (auth keys)
Owner
|
Thanks for suggesting this - it would be good to separate the storage of the user credentials and the RTM CLI configuration. I just renamed the extra config file to use ~/.rtm.config.json by default since it could be used to store other config properties in addition to the aliases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows placing aliases in a separate config file ($HOME/.rtm.aliases.json) so you have the option of independently storing those in source control. Putting the $HOME/.rtm.json into source control is challenging because it contains private access keys to the RTM account (and it's good security practice to not store keys in github), so you have to jump through hoops in order to save your aliases.
This is a simple work around for this, by having a second file read upon startup that loads in the aliases file after the default user config is loaded. There may be a better way, but this was the most straight forward.